Add git hook for updating the copyright as part of pre-commit #423
Conversation
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
copyright_hook
branch
from
7adc23d to
fa9ae2c
Compare
|
|
||
| # Configure git to use .githooks directory | ||
| subprocess.run( | ||
| ['git', 'config', 'core.hooksPath', str(githooks_dir)], |
There was a problem hiding this comment.
There are four levels of githooks...
--global --system --local --worktree
five if you consider the rare --blob ability (which probably not worrisome here).
The pathing , while I have no native concern, may be in conflict with a users pre-configured environment. Are we certain this stacks, or it is replacing the users existing environment, if so how is it restored?
Another thought
This I assume, is targeting only implied --local behavior since no option is provided.
However, if the user has their environment to use --global will this be ignored entirely...
Summary, is this something we want to get into, i.e. configuring for them, or simply put some docs in and leave it at that, if they wish to manage multiple hooks, folder, etc.. they probably need to copy/paste or something
| To enable automatic copyright year updates and other git hooks, run: | ||
|
|
||
| ```bash | ||
| python3 .githooks/setup.py |
There was a problem hiding this comment.
Pending your thoughts on my prior comments for git config options, we may want to change this to simply give instructions for them to copy/paste the pre-commit file to someplace they have enabled... And/or change the script to simply check if hooks are enabled, inform them, and then see if the pre-commit file is in their path.
2 participants
No description provided.